Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow a space after the namespace we're searching for #84

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Allow a space after the namespace we're searching for #84

merged 1 commit into from
Nov 23, 2020

Conversation

BrianHenryIE
Copy link
Contributor

Fix for #75. Edits @markjaquith 's regex to add \s. I think it's a safe change. Test added and existing NamespaceReplacerTests all pass.

@coenjacobs
Copy link
Owner

Nice find, @BrianHenryIE!

@coenjacobs coenjacobs merged commit c0305c9 into coenjacobs:master Nov 23, 2020
@BrianHenryIE BrianHenryIE mentioned this pull request Dec 13, 2020
Merged
@BrianHenryIE
Copy link
Contributor Author

This is causing me problems with type annotations in function arguments. Specifically with mpdf/mpdf. I'll write a failing test soon.

@BrianHenryIE BrianHenryIE mentioned this pull request Feb 17, 2021
Open
@BrianHenryIE BrianHenryIE deleted the use-namespace-as-75 branch May 3, 2021 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrianHenryIE @coenjacobs